[libvirt] [PATCH] locking: Use bit shift for flag values not constant values.

Peter Krempa pkrempa at redhat.com
Mon Mar 7 09:46:26 UTC 2016


On Fri, Mar 04, 2016 at 09:39:35 -0500, John Ferlan wrote:
> So far it hasn't bitten us, but if the next value wasn't 4, then
> the logic used to check flag bits would have issues.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---

ACK, the second power could be mistaken with a sequential numbering.
After that it's again pretty obvious.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160307/4ea27ac1/attachment-0001.sig>


More information about the libvir-list mailing list