[libvirt] [PATCH 2/3] conf: Fix off-by-one in virDomainDefGetVcpu
Jiri Denemark
jdenemar at redhat.com
Thu Mar 10 12:48:15 UTC 2016
On Thu, Mar 10, 2016 at 10:03:52 +0100, Peter Krempa wrote:
> Cpus are indexed starting from '0' so the check was invalid.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1316384
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1316420
> ---
> src/conf/domain_conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 314a584..1aed318 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -1405,7 +1405,7 @@ virDomainVcpuInfoPtr
> virDomainDefGetVcpu(virDomainDefPtr def,
> unsigned int vcpu)
> {
> - if (vcpu > def->maxvcpus) {
> + if (vcpu >= def->maxvcpus) {
> virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> _("vCPU '%u' is not present in domain definition"),
> vcpu);
ACK
Jirka
More information about the libvir-list
mailing list