[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 15/24] hostdev: Remove virHostdevGetActivePCIHostDeviceList()

On Thu, 2016-03-10 at 14:25 -0500, John Ferlan wrote:
> <SIGH>  Should have read patch 18 & 19 first... Looks like I'm getting
> confuzzled by all these lists and multitude of ways names were
> generated. The comparison being done is against the copy that came from
> the activePCIHostdev list which will have the fields I was concerned
> about. So in retrospect...

To be fair, patches 18 and 19 were written *exactly* to make it a
tiny bit easier to follow along, especially with patch 21 in mind.

It would probably have been better if the name changes had been
made *before* changing the code too much, as this patch is doing,
but the comments in patch 19 would not really be true if patch 15
had not been applied first, so... Rock and hard place, really :(

I'll reply to your other concern down the thread, consider this
just an aside.


Andrea Bolognani
Software Engineer - Virtualization Team

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]