[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] virlog: Change virLogDestination to virLogDestinationType



On Wed, Mar 16, 2016 at 12:05:33PM +0100, Erik Skultety wrote:
> This will later utilize our VIR_ENUM_{DECL,IMPL} macros, so stay consistent
> with the rest of the library.

We do not use *Type everywhere and I think it looks nicer without it.

> Also, this includes adding an explicit sentinel
> _LAST to the enum.

This addition would better fit in the next patch which uses it in
VIR_ENUM_IMPL.

Jan

> ---
>  src/util/virlog.c | 6 +++---
>  src/util/virlog.h | 5 +++--
>  2 files changed, 6 insertions(+), 5 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]