[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/8] tests: Add failure flags to CompareDomainXML2XML




On 03/08/2016 11:36 AM, Cole Robinson wrote:
> Will be used in future patches

Could be beefed up to indicate how it's expected to be used...

> ---
>  tests/bhyvexml2xmltest.c   |  2 +-
>  tests/genericxml2xmltest.c |  2 +-
>  tests/lxcxml2xmltest.c     |  2 +-
>  tests/qemuxml2xmltest.c    |  5 +++--
>  tests/testutils.c          | 10 ++++++++--
>  tests/testutils.h          |  4 ++++
>  6 files changed, 18 insertions(+), 7 deletions(-)
> 

soft ACK (looks right, but I'm just not as fluent in tests changes as I
should be ;-))

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]