[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] Adjust order of calls during qemuDomainRemoveHostDevice

On 03/28/2016 07:52 AM, John Ferlan wrote:
While reviewing patch:


I noted that the order of operations during the code path was slightly
different and could cause issues if the reattachment code was called
first. It would seem that resetting the hostdev label and cgroup prior
to reattaching the device to the host would be a better corollary to
the attachment code path which detaches the devices from the host, then
sets the cgroup, then sets the hostdev label.

I've noticed similar issues at other places in the code (teardown not being the exact mirror image of setup) but didn't touch it because I didn't want to accidentally introduce regressions.

I wanted to test these patches to verify that the sequence change doesn't uncover some odd regression, but now I find that hotplug of type='hostdev' network devices is completely broken (even before applying your patches), so I'll have to figure out the cause of that first :-/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]