[libvirt] [For 1.3.3 1/2] libxl: fix attaching net device of type hostdev

Daniel P. Berrange berrange at redhat.com
Thu Mar 31 15:14:29 UTC 2016


On Wed, Mar 30, 2016 at 04:36:02PM -0600, Jim Fehlig wrote:
> Chunyan sent a correct patch to fix a resource leak on error in
> libxlDomainAttachNetDevice
> 
> https://www.redhat.com/archives/libvir-list/2016-March/msg00924.html
> 
> I made what was thought to be an improvement and pushed the patch as
> commit e6336442. As it turns out, my change broke adding net devices
> that are actually hostdevs to the list of nets in virDomainDef. This
> patch changes e6336442 to resemble Chunyan's original, correct
> patch.
> 
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> ---
>  src/libxl/libxl_driver.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list