[libvirt] [PATCH] build: fix 32-bit build of admin

Eric Blake eblake at redhat.com
Wed May 4 19:19:34 UTC 2016

We can't guarantee which 64-bit type will be used in an RPC struct;
while %lu worked on 64-bit Linux, that won't always be the type
used on all 64-bit platforms; and certainly is not right for 32-bit:

admin.c: In function 'adminDispatchClientGetInfo':
admin.c:265:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]

Signed-off-by: Eric Blake <eblake at redhat.com>

Pushing under the build-breaker rule

 daemon/admin.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/daemon/admin.c b/daemon/admin.c
index 3de09ca..dbf49dd 100644
--- a/daemon/admin.c
+++ b/daemon/admin.c
@@ -262,8 +262,8 @@ adminDispatchClientGetInfo(virNetServerPtr server ATTRIBUTE_UNUSED,

     if (!(clnt = virNetServerGetClient(srv, args->clnt.id))) {
-                      _("no client with matching id '%lu' found"),
-                      args->clnt.id);
+                       _("no client with matching id '%llu' found"),
+                       (unsigned long long) args->clnt.id);
         goto cleanup;


More information about the libvir-list mailing list