[libvirt] [PATCH v3 0/2] Add IV Secret Object support (for RBD only)

John Ferlan jferlan at redhat.com
Thu May 5 19:00:39 UTC 2016

v2 here:

First 6 patches from v2 were pushed since they were ACK'd

I modified the 7th patch to add the ATTRIBUTE_UNUSED to the static
functions qemuDomainSecretHaveEncypt and qemuDomainSecretIVSetup and

This should address Michal's point in patch 7 review.

Patch 2 thus becomes the "remainder" of the work necessary in order
to get IV Secrets available for RBD volumes. It's most of the former
patch 8 with removal if iSCSI oddities.

Patch 8 will then remove the ATTRIBUTE_UNUSED from the 2 static functions
now that qemuDomainSecretSetup exists to call it.  The change here was
to add the check for protocol == VIR_STORAGE_NET_PROTOCOL_RBD before
"defaulting" to using the IV secret (e.g., the magic decision point).

Since the command code didn't need the secret setup for iSCSI, it's been
extracted to another safe place just in case it needs to be resurrected.

John Ferlan (2):
  qemu: Introduce new Secret IV API's
  qemu: Utilize qemu secret objects for RBD auth/secret

 configure.ac                                       |   1 +
 src/qemu/qemu_alias.c                              |  23 +++
 src/qemu/qemu_alias.h                              |   2 +
 src/qemu/qemu_command.c                            | 130 +++++++++++++-
 src/qemu/qemu_domain.c                             | 189 ++++++++++++++++++++-
 ...emuxml2argv-disk-drive-network-rbd-auth-IV.args |  31 ++++
 ...qemuxml2argv-disk-drive-network-rbd-auth-IV.xml |  42 +++++
 tests/qemuxml2argvmock.c                           |  31 +++-
 tests/qemuxml2argvtest.c                           |  11 ++
 9 files changed, 451 insertions(+), 9 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth-IV.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd-auth-IV.xml


More information about the libvir-list mailing list