[libvirt] [PATCH] qemu: domain: Don't treat unknown storage type as not having backing chain

Peter Krempa pkrempa at redhat.com
Fri May 6 13:48:52 UTC 2016

qemuDomainCheckDiskPresence has short-circuit code to skip the
determination of the disk backing chain for storage formats that can't
have backing volumes. The code treats VIR_STORAGE_FILE_NONE as not
having backing chain and skips the call to qemuDomainDetermineDiskChain.

This is wrong as qemuDomainDetermineDiskChain is responsible for storage
format detection and has logic to determine the default type if format
detection is disabled.

This allows to storage passed via <disk type="volume"> to circumvent the
enforcement to have correct storage format or that we shall default to
format='raw', since we don't set the default type via the post parse
callback for "volume" backed disks as the translation code could come up
with a better guess.

This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1328003
 src/qemu/qemu_domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index cae356c..78a717a 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -3817,7 +3817,7 @@ qemuDomainCheckDiskPresence(virQEMUDriverPtr driver,
          * without backing support, the fact that the file exists is
          * more than enough */
         if (virStorageSourceIsLocalStorage(disk->src) &&
-            format >= VIR_STORAGE_FILE_NONE &&
+            format > VIR_STORAGE_FILE_NONE &&
             format < VIR_STORAGE_FILE_BACKING &&

More information about the libvir-list mailing list