[libvirt] [PATCH] qemu: domain: Don't treat unknown storage type as not having backing chain

Peter Krempa pkrempa at redhat.com
Mon May 9 07:42:14 UTC 2016

On Fri, May 06, 2016 at 11:23:13 -0400, John Ferlan wrote:


> Do you believe it still would be worthwhile to add:
>     if (virDomainDiskGetFormat(def) == VIR_STORAGE_FILE_NONE)
>         virDomainDiskSetFormat(def, VIR_STORAGE_FILE_RAW);
> in virStorageTranslateDiskSourcePool in the ISCSI case for MODE_HOST?

You can do that only if format detection is disabled, otherwise it would
not be possible to use it. The rest of the code needs to handle the
possibility that the format needs to be detected.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160509/a9312cd4/attachment-0001.sig>

More information about the libvir-list mailing list