[libvirt] [PATCH] admin: Fix passing an incorrect readonly attribute to virNetServerServiceNew

Erik Skultety eskultet at redhat.com
Sat May 14 17:30:52 UTC 2016


When registering admin UNIX socket, a new service is created for it. This
service is incorrectly initialized to be readonly, which is later inherited by
all clients connected to the socket. In libvirt-admin's case there currently
isn't any use for the attribute anyway, but since the socket has root-only
access permissions, but the least we can do is to make every admin client
connected to it report readonly as false.

Signed-off-by: Erik Skultety <eskultet at redhat.com>
---
 daemon/libvirtd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index cc5190f..f24fb22 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -543,7 +543,7 @@ daemonSetupNetworking(virNetServerPtr srv,
 #if WITH_GNUTLS
                                                   NULL,
 #endif
-                                                  true,
+                                                  false,
                                                   config->admin_max_queued_clients,
                                                   config->admin_max_client_requests)))
             goto cleanup;
-- 
2.5.5




More information about the libvir-list mailing list