[libvirt] [PATCH 1/6] conf: disk: Rename virDomainDiskDefValidate to virDomainDiskDefParseValidate

Peter Krempa pkrempa at redhat.com
Tue May 17 14:25:37 UTC 2016


Name the validation function distinctively since it's called in the
parser. Later patches will add function that will validate disk
definitions that are invalid but need to be parsed to avoid losing
domains.
---
 src/conf/domain_conf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b445469..12f9da2 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6932,7 +6932,7 @@ virDomainDiskDefGeometryParse(virDomainDiskDefPtr def,


 static int
-virDomainDiskDefValidate(const virDomainDiskDef *def)
+virDomainDiskDefParseValidate(const virDomainDiskDef *def)
 {
     if (def->bus != VIR_DOMAIN_DISK_BUS_VIRTIO) {
         if (def->event_idx != VIR_TRISTATE_SWITCH_ABSENT) {
@@ -7537,7 +7537,7 @@ virDomainDiskDefParseXML(virDomainXMLOptionPtr xmlopt,
             goto error;
     }

-    if (virDomainDiskDefValidate(def) < 0)
+    if (virDomainDiskDefParseValidate(def) < 0)
         goto error;

  cleanup:
-- 
2.8.2




More information about the libvir-list mailing list