[libvirt] [PATCH 0/6] auto-assign addresses when <address type='pci'/> is specified

Laine Stump laine at laine.org
Wed May 18 19:23:48 UTC 2016

This is an alternative to Cole's series that permits <address
type='pci'/> to force assignment of a PCI address, which is
particularly useful on platforms that could connect the same device in
different ways (e.g. aarch64/virt).

Here is Cole's last iteration of the series:


I had expressed a dislike of the "auto_allocate" flag that his series
temporarily adds to the address (while simultaneously changing the
address type to NONE) and suggested just changing all the necessary
places to check for a valid PCI address instead of just checking the
address type. He replied that this wasn't as simple as it looked, so I
decided to try it; turns out he's right. But I still like this method
better because it's not playing tricks with the address type, or
adding a temporary private attribute to what should be pure config

Your opinion may vary though :-)

Note that patch 5/6 incorporates the same test case that Cole used in
his penultimate patch, and I've added his patch to check the case of
aarch64 at the end as well.

Cole Robinson (1):
  tests: qemu: test <address type='pci'/> with aarch64

Laine Stump (5):
  conf: move virDomainDeviceInfo definition from domain_conf.h to
  conf: new functions to check if PCI address is wanted/present
  conf: allow type='pci' addresses with no address attributes specified
  bhyve: auto-assign addresses when <address type='pci'/> is specified
  qemu: auto-assign addresses when <address type='pci'/> is specified

 docs/schemas/basictypes.rng                        |   8 +-
 src/bhyve/bhyve_device.c                           |  10 +-
 src/conf/device_conf.c                             |   6 +-
 src/conf/device_conf.h                             | 132 ++++++++++++++++++++-
 src/conf/domain_addr.c                             |   2 +-
 src/conf/domain_conf.c                             |  13 +-
 src/conf/domain_conf.h                             | 129 --------------------
 src/qemu/qemu_domain_address.c                     |  64 +++++-----
 ...l2argv-aarch64-virtio-pci-manual-addresses.args |   4 +-
 ...ml2argv-aarch64-virtio-pci-manual-addresses.xml |   5 +
 .../qemuxml2argv-pci-autofill-addr.args            |  25 ++++
 .../qemuxml2argv-pci-autofill-addr.xml             |  35 ++++++
 tests/qemuxml2argvtest.c                           |   1 +
 ...2xmlout-aarch64-virtio-pci-manual-addresses.xml |   5 +
 .../qemuxml2xmlout-pci-autofill-addr.xml           |  41 +++++++
 tests/qemuxml2xmltest.c                            |   1 +
 16 files changed, 298 insertions(+), 183 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-autofill-addr.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pci-autofill-addr.xml
 create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-pci-autofill-addr.xml


More information about the libvir-list mailing list