[libvirt] [PATCH] tests: nodeinfotest: Remove virSaveLastError() usage

Cole Robinson crobinso at redhat.com
Thu May 19 19:27:08 UTC 2016


It's overkill here, we can use virGetLast* instead
---
 tests/nodeinfotest.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/nodeinfotest.c b/tests/nodeinfotest.c
index d8eace5..03500fb 100644
--- a/tests/nodeinfotest.c
+++ b/tests/nodeinfotest.c
@@ -44,10 +44,8 @@ linuxTestCompareFiles(char *sysfs_prefix,
     memset(&nodeinfo, 0, sizeof(nodeinfo));
     if (linuxNodeInfoCPUPopulate(sysfs_prefix, cpuinfo, arch, &nodeinfo) < 0) {
         if (virTestGetDebug()) {
-            virErrorPtr error = virSaveLastError();
-            if (error && error->code != VIR_ERR_OK)
-                VIR_TEST_DEBUG("\n%s\n", error->message);
-            virFreeError(error);
+            if (virGetLastError())
+                VIR_TEST_DEBUG("\n%s\n", virGetLastErrorMessage());
         }
         VIR_FORCE_FCLOSE(cpuinfo);
         goto fail;
-- 
2.7.4




More information about the libvir-list mailing list