[libvirt] [PATCH] Call qemuDomainObjEndJob when qemuCaps is null during hotplug
Pavel Hrdina
phrdina at redhat.com
Wed May 25 10:36:35 UTC 2016
On Wed, May 25, 2016 at 03:49:04AM -0500, Shivaprasad G Bhat wrote:
> Signed-off-by: Shivaprasad G Bhat <sbhat at linux.vnet.ibm.com>
> ---
> src/qemu/qemu_driver.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 249393a..3f26f1f 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -8237,7 +8237,7 @@ qemuDomainAttachDeviceFlags(virDomainPtr dom,
> if (priv->qemuCaps)
> qemuCaps = virObjectRef(priv->qemuCaps);
> else if (!(qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, vm->def->emulator)))
> - goto cleanup;
> + goto endjob;
>
> if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
> /* Make a copy for updated domain. */
> @@ -8490,7 +8490,7 @@ qemuDomainDetachDeviceFlags(virDomainPtr dom,
> if (priv->qemuCaps)
> qemuCaps = virObjectRef(priv->qemuCaps);
> else if (!(qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, vm->def->emulator)))
> - goto cleanup;
> + goto endjob;
>
> if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
> /* Make a copy for updated domain. */
The same bug is also on line 8369, could you fix that too and send a v2?
Pavel
More information about the libvir-list
mailing list