[libvirt] [PATCH v2 15/19] tests: Rename virtTestDifferenceBin to virTestDifferenceBin.

Tomáš Ryšavý tom.rysavy.0 at gmail.com
Thu May 26 15:02:04 UTC 2016


This function doesn't follow our convention of naming functions.
---
 tests/testutils.c         | 8 ++++----
 tests/testutils.h         | 8 ++++----
 tests/virnetmessagetest.c | 6 +++---
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/tests/testutils.c b/tests/testutils.c
index 34f2410..111139a 100644
--- a/tests/testutils.c
+++ b/tests/testutils.c
@@ -625,10 +625,10 @@ virTestDifference(FILE *stream,
  * Display expected and actual output text, trimmed to
  * first and last characters at which differences occur
  */
-int virtTestDifferenceBin(FILE *stream,
-                          const char *expect,
-                          const char *actual,
-                          size_t length)
+int virTestDifferenceBin(FILE *stream,
+                         const char *expect,
+                         const char *actual,
+                         size_t length)
 {
     size_t start = 0, end = length;
     ssize_t i;
diff --git a/tests/testutils.h b/tests/testutils.h
index 23a687d..c79438e 100644
--- a/tests/testutils.h
+++ b/tests/testutils.h
@@ -69,10 +69,10 @@ int virtTestDifferenceFullNoRegenerate(FILE *stream,
                                        const char *expectName,
                                        const char *actual,
                                        const char *actualName);
-int virtTestDifferenceBin(FILE *stream,
-                          const char *expect,
-                          const char *actual,
-                          size_t length);
+int virTestDifferenceBin(FILE *stream,
+                         const char *expect,
+                         const char *actual,
+                         size_t length);
 int virTestCompareToFile(const char *strcontent,
                          const char *filename);
 
diff --git a/tests/virnetmessagetest.c b/tests/virnetmessagetest.c
index bed92bb..8189031 100644
--- a/tests/virnetmessagetest.c
+++ b/tests/virnetmessagetest.c
@@ -77,7 +77,7 @@ static int testMessageHeaderEncode(const void *args ATTRIBUTE_UNUSED)
     }
 
     if (memcmp(expect, msg->buffer, sizeof(expect)) != 0) {
-        virtTestDifferenceBin(stderr, expect, msg->buffer, sizeof(expect));
+        virTestDifferenceBin(stderr, expect, msg->buffer, sizeof(expect));
         goto cleanup;
     }
 
@@ -269,7 +269,7 @@ static int testMessagePayloadEncode(const void *args ATTRIBUTE_UNUSED)
     }
 
     if (memcmp(expect, msg->buffer, sizeof(expect)) != 0) {
-        virtTestDifferenceBin(stderr, expect, msg->buffer, sizeof(expect));
+        virTestDifferenceBin(stderr, expect, msg->buffer, sizeof(expect));
         goto cleanup;
     }
 
@@ -511,7 +511,7 @@ static int testMessagePayloadStreamEncode(const void *args ATTRIBUTE_UNUSED)
     }
 
     if (memcmp(expect, msg->buffer, sizeof(expect)) != 0) {
-        virtTestDifferenceBin(stderr, expect, msg->buffer, sizeof(expect));
+        virTestDifferenceBin(stderr, expect, msg->buffer, sizeof(expect));
         goto cleanup;
     }
 
-- 
2.5.5




More information about the libvir-list mailing list