[libvirt] [PATCH 1/6] virNetDevBridgeGet: Avoid NULL dereference

Peter Krempa pkrempa at redhat.com
Tue May 31 11:06:48 UTC 2016


On Tue, May 31, 2016 at 12:33:25 +0200, Michal Privoznik wrote:
> It may happen, that this function would dereference a NULL
> pointer:
> 
> util/virnetdevbridge.c: In function 'virNetDevBridgeGetVlanFiltering':
> util/virnetdevbridge.c:199:23: error: null pointer dereference [-Werror=null-dereference]
>          ifr->ifr_data = (char*)&args;
>          ~~~~~~~~~~~~~~^~~~~~~~~~~~~~
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/util/virnetdevbridge.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

How about fixing the single caller that passes NULL in @ifr?

virNetDevBridgeGetVlanFiltering
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160531/4a63c519/attachment-0001.sig>


More information about the libvir-list mailing list