[libvirt] [PATCH 1/3] qemu: parse: Use virControllerDefNew
Cole Robinson
crobinso at redhat.com
Mon May 2 23:47:41 UTC 2016
On 05/02/2016 07:44 PM, John Ferlan wrote:
>
>
> On 04/27/2016 02:29 PM, Cole Robinson wrote:
>> Rather than reimplement it. This will be needed in upcoming patches
>> ---
>> src/conf/domain_conf.c | 2 +-
>> src/conf/domain_conf.h | 2 ++
>> src/libvirt_private.syms | 1 +
>> src/qemu/qemu_parse_command.c | 8 +++-----
>> 4 files changed, 7 insertions(+), 6 deletions(-)
>>
>
> ACK for what's here... kudos for even considering qemu_parse_command -
> it's certainly the forgotten step-child.
>
In truth I didn't intentionally consider it... later patches break the test
suite without this :)
> Would it be worth modifying qemuDomainFindOrCreateSCSIDiskController
> too? I was just searching on other places where a VIR_ALLOC() was done
> for a virDomainControllerDefPtr.
>
It's the 'more correct' thing to do but won't have any real functional impact,
since ControllerDefNew is only needed for virtio-serial and (now) usb controllers
- Cole
More information about the libvir-list
mailing list