[libvirt] [PATCH 3/7] Return void in qemuDomainAssignARMVirtioMMIOAddresses

Ján Tomko jtomko at redhat.com
Tue May 3 10:47:23 UTC 2016


This function does not fail and it does not need to return anything.
---
 src/qemu/qemu_domain_address.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c
index c651dce..f149ff9 100644
--- a/src/qemu/qemu_domain_address.c
+++ b/src/qemu/qemu_domain_address.c
@@ -398,7 +398,7 @@ qemuDomainAssignS390Addresses(virDomainDefPtr def,
 }
 
 
-static int
+static void
 qemuDomainAssignARMVirtioMMIOAddresses(virDomainDefPtr def,
                                        virQEMUCapsPtr qemuCaps)
 {
@@ -411,7 +411,6 @@ qemuDomainAssignARMVirtioMMIOAddresses(virDomainDefPtr def,
         qemuDomainPrimeVirtioDeviceAddresses(
             def, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO);
     }
-    return 0;
 }
 
 
@@ -1659,9 +1658,7 @@ qemuDomainAssignAddresses(virDomainDefPtr def,
     if (rc)
         return rc;
 
-    rc = qemuDomainAssignARMVirtioMMIOAddresses(def, qemuCaps);
-    if (rc)
-        return rc;
+    qemuDomainAssignARMVirtioMMIOAddresses(def, qemuCaps);
 
     return qemuDomainAssignPCIAddresses(def, qemuCaps, obj);
 }
-- 
2.7.3




More information about the libvir-list mailing list