[libvirt] [PATCH] qemu: hotplug: Report error if we hit tray status timeout

[Cole Robinson]

On 05/03/2016 08:23 AM, Cole Robinson wrote:
> On 05/03/2016 02:24 AM, Peter Krempa wrote:
>> On Mon, May 02, 2016 at 19:09:35 -0400, Cole Robinson wrote:
>>> If we exceed the timeout waiting for the tray status to change,
>>> we don't report an error. Fix it
>>> ---
>>> I hit this trying to eject floppy media for a win10 VM with F24
>>> qemu, but I didn't dig deeper to figure out _why_ it's timing out...
>>
>> Did you try it after:
>>
>> commit a34faf33011c5c0d7b47ee0849bf1e11635e17c5
>> Author: Peter Krempa <pkrempa at redhat.com>
>> Date:   Fri Apr 29 13:38:51 2016 +0200
>>
>>     qemu: process: Refresh ejectable media tray state on VM start
>>     
>>     Empty floppy drives start with tray in "open" state and libvirt did not
>>     refresh it after startup. The code that inserts media into the tray then
>>     waited until the tray was open before inserting the media and thus
>>     floppies could not be inserted.
>>     
>>     Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1326660
>>
>> If not, then that's the reason, and the fix below doesn't make much
>> sense.
>>
> 
> I just double checked: with current libvirt.git + qemu 2.6.0, trying to eject
> floppy media via virt-manager will return 'An error occurred, but the cause is
> unknown'. After my patch it at least reports an error
> 

To clarify a bit, the case I was testing is starting a VM with media already
in the floppy drive, then trying to eject it, which doesn't exactly match the
commit message so maybe there's a mismatch somewhere

- Cole