Re: [libvirt] [PATCH 06/17] genericxml2xml: add several graphics tests

[Pavel Hrdina <phrdina redhat com>]

On Fri, May 06, 2016 at 02:33:03PM +0200, Peter Krempa wrote:
> On Thu, May 05, 2016 at 18:20:25 +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina redhat com>
> > ---
> 
> [...]
> 
> > diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c
> > index 70a5203..70ecd2d 100644
> > --- a/tests/genericxml2xmltest.c
> > +++ b/tests/genericxml2xmltest.c
> > @@ -77,9 +77,16 @@ mymain(void)
> >  
> >      DO_TEST_DIFFERENT("disk-virtio");
> >  
> > +    DO_TEST_DIFFERENT("graphics-vnc-minimal");
> > +    DO_TEST_DIFFERENT("graphics-vnc-manual-port");
> > +    DO_TEST_DIFFERENT("graphics-vnc-socket");
> > +    DO_TEST_DIFFERENT("graphics-vnc-socket-listen");
> >      DO_TEST_DIFFERENT("graphics-listen-back-compat");
> >      DO_TEST_FULL("graphics-listen-back-compat-mismatch", 0, false,
> >          TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_PARSE);
> > +    DO_TEST_DIFFERENT("graphics-vnc-listen-attr-only");
> > +    DO_TEST_DIFFERENT("graphics-vnc-listen-element-minimal");
> > +    DO_TEST_DIFFERENT("graphics-vnc-listen-element-with-address");
> 
> I guess the test case names are self explanatory enough to require a
> commit message describing the tests.
> 
> ACK

Thanks, I've pushed patches 1-6 except patch 4.

Pavel