[libvirt] [PATCH 4/8] qemu: command: Use more appropriate checking function for block devices

Peter Krempa pkrempa at redhat.com
Mon May 9 11:34:10 UTC 2016


On Fri, May 06, 2016 at 11:09:38 -0400, John Ferlan wrote:
> 
> 
> On 05/02/2016 10:32 AM, Peter Krempa wrote:
> > In qemuCheckDiskConfig would now use virDomainDiskSourceIsBlockType just
> > as a glorified version of virStorageSourceIsBlockLocal that reports
> > error messages. Replace it with the latter including the message for
> > clarity.
> > ---
> >  src/qemu/qemu_command.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> 
> Hmmm... I wonder if the previous commit should remove or at least
> reference the check in virDomainDiskSourceIsBlockType that neglected to

I don't see a point in doing this since that function is removed in the
next patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160509/52e4e3ad/attachment-0001.sig>


More information about the libvir-list mailing list