[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/8] qemu: command: Use more appropriate checking function for block devices



On Fri, May 06, 2016 at 11:09:38 -0400, John Ferlan wrote:
> 
> 
> On 05/02/2016 10:32 AM, Peter Krempa wrote:
> > In qemuCheckDiskConfig would now use virDomainDiskSourceIsBlockType just
> > as a glorified version of virStorageSourceIsBlockLocal that reports
> > error messages. Replace it with the latter including the message for
> > clarity.
> > ---
> >  src/qemu/qemu_command.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> 
> Hmmm... I wonder if the previous commit should remove or at least
> reference the check in virDomainDiskSourceIsBlockType that neglected to

I don't see a point in doing this since that function is removed in the
next patch.

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]