[libvirt] [PATCHv2] virsh: blkdeviotune: accept human readable values for bytes

Nishith Shah nishithshah.2211 at gmail.com
Tue May 10 02:41:10 UTC 2016


On Mon, May 9, 2016 at 11:32 AM, Michal Privoznik <mprivozn at redhat.com>
wrote:

> On 04.05.2016 16:25, Nishith Shah wrote:
>
> [1] .. here.
>
> > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so that
> > values with suffixes can be passed when bytes are being passed along.
> > Values for the iops parameters still need to be given in the absolute
> > form as they are not bytes but numbers. Please refer to the bug link
> > https://bugzilla.redhat.com/show_bug.cgi?id=885380 which can be closed.
>
> I've moved this bug reference [1]. It's our common way of referring bugs
> in commit messages.
>
Thanks for the pointer, I'll keep that in mind in future commit messages.

>
> >
> > Signed-off-by: Nishith Shah <nishithshah.2211 at gmail.com>
> > ---
> >  tools/virsh-domain.c | 24 ++++++++++++------------
> >  tools/virsh.pod      | 18 ++++++++++++------
> >  2 files changed, 24 insertions(+), 18 deletions(-)
>
> ACKed and pushed.
>
> Congratulations on your first libvirt contribution!
>
Thank you :) Looking forward to more!

Nishith
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160510/1ee21d8b/attachment-0001.htm>


More information about the libvir-list mailing list