[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 04/12] domain_conf: cleanup virDomainGraphicsListenDefParseXML



On Wed, May 11, 2016 at 5:08 PM, Pavel Hrdina <phrdina redhat com> wrote:
> Signed-off-by: Pavel Hrdina <phrdina redhat com>
> ---
>  src/conf/domain_conf.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index e70456d..cd06384 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -10708,10 +10708,9 @@ virDomainGraphicsListenDefParseXML(virDomainGraphicsListenDefPtr def,
>
>      if (network && network[0]) {
>          if (def->type != VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK) {
> -            /* network='xxx' never makes sense with anything except
> -             * type='network' */
>              virReportError(VIR_ERR_XML_ERROR, "%s",
> -                           _("network attribute not allowed when listen type is not network"));
> +                           _("'network' attribute is valid only for listen "
> +                             "type 'network'"));
>              goto error;
>          }

Reviewed-by: Marc-André Lureau <marcandre lureau redhat com>


>          def->network = network;
> --
> 2.8.2
>
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list



-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]