[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 08/12] spice: add support for listen type socket



On Thu, May 12, 2016 at 01:17:54PM +0200, Christophe Fergeau wrote:
> Hey,
> 
> On Wed, May 11, 2016 at 05:08:27PM +0200, Pavel Hrdina wrote:
> > @@ -7665,40 +7694,12 @@ qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg,
> >              break;
> >  
> >          case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_INSECURE:
> > -            if (glisten->port <= 0) {
> > -                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> > -                               _("spice insecure channels set in XML "
> > -                                 "configuration, but plain port is not provided"));
> > -                goto error;
> > -            }
> >              virBufferAsprintf(&opt, "plaintext-channel=%s,",
> >                                virDomainGraphicsSpiceChannelNameTypeToString(i));
> >              break;
> >  
> >          case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_ANY:
> > -            switch (defaultMode) {
> > -            case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_SECURE:
> > -                if (glisten->tlsPort <= 0) {
> > -                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> > -                                   _("spice defaultMode secure requested in XML "
> > -                                     "configuration but TLS port not provided"));
> > -                    goto error;
> > -                }
> > -                break;
> > -
> > -            case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_INSECURE:
> > -                if (glisten->port <= 0) {
> > -                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> > -                                   _("spice defaultMode insecure requested in XML "
> > -                                     "configuration but plain port not provided"));
> > -                    goto error;
> > -                }
> > -                break;
> > -
> > -            case VIR_DOMAIN_GRAPHICS_SPICE_CHANNEL_MODE_ANY:
> > -                /* don't care */
> >              break;
> > -            }
> >          }
> >      }
> 
> Didn't we lose the error when asking for plaintext channels without
> setting a non-secure port?
> 
> Christophe

Yes, we lose that error and I have a v3 that fixes it already prepared.
I'm just waiting in case someone else wants to review this series.

Thanks,

Pavel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]