[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v2 0/4] Don't disable auto_login for iSCSI targets

v1: http://www.redhat.com/archives/libvir-list/2016-May/msg01027.html

Changes since v2:

* Patch 2
 * Remove the 'str' fetch/free - it was unnecessary
 * Initialize and free 'error'

 * Did not adjust reported error since with the usage of exitstatus
   the call to virCommandRunRegex, that means the virCommandWait code
   will return the error rather than reporting it. So the reporting is
   left to this code to handle. Kept the same error code (INTERNAL) as

Patch 3-5
 * Remove 3, combine 4 & 5, but remove the setting of the autologin for
   libvirt managed targets.  This is essentially Fritz's initial patch:


   but with the adjustment to add the "ATTRIBUTE_UNUSED" for the
   initiatoriqn parameter (it'll be removed in the next patch as
   it is a bit more invasive).

Fritz Elfert (1):
  util: Remove disabling of autologin for iscsi-targets

John Ferlan (3):
  util: Add exitstatus parameter to virCommandRunRegex
  iscsi: Add exit status checking for virISCSIGetSession
  iscsi: Remove initiatoriqn from virISCSIScanTargets

 src/storage/storage_backend_fs.c      |  2 +-
 src/storage/storage_backend_iscsi.c   |  8 ++---
 src/storage/storage_backend_logical.c | 10 +++---
 src/util/vircommand.c                 |  9 ++++--
 src/util/vircommand.h                 |  3 +-
 src/util/viriscsi.c                   | 60 +++++++++++++++--------------------
 src/util/viriscsi.h                   |  1 -
 tests/viriscsitest.c                  |  7 ++--
 8 files changed, 46 insertions(+), 54 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]