[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH V2 0/3] correct libxl config file convert



Chunyan Liu wrote:
> Correct libxl config file type=vif handling.
> 
> ---
> Changes in v2:
>   * update xen{Parse,Format}ConfigCommon parameter vif_typename to
>     nativeFomat. To reuse XEN_CONFIG_FORMAT_{XM,XL}, first extract
>     XEN_CONFIG_FORMAT_{XM,XL} to xen_common.h
> 
> Chunyan Liu (3):
>   extract XEN_CONFIG_FORMAT_XM/XL to xen_common.h
>   xenFormatNet: correct `type=netfront' to 'type=vif' to match libxl
>   xlconfigtest: add test case for type=vif in xl format
> 
>  src/libxl/libxl_driver.c                 | 14 ++++------
>  src/xen/xen_driver.h                     |  3 ---
>  src/xenconfig/xen_common.c               | 43 ++++++++++++++++++++++--------
>  src/xenconfig/xen_common.h               | 10 +++++--
>  src/xenconfig/xen_xl.c                   |  4 +--
>  src/xenconfig/xen_xm.c                   |  4 +--
>  tests/xlconfigdata/test-vif-typename.cfg | 25 ++++++++++++++++++
>  tests/xlconfigdata/test-vif-typename.xml | 45 ++++++++++++++++++++++++++++++++
>  tests/xlconfigtest.c                     |  1 +
>  9 files changed, 120 insertions(+), 29 deletions(-)
>  create mode 100644 tests/xlconfigdata/test-vif-typename.cfg
>  create mode 100644 tests/xlconfigdata/test-vif-typename.xml

ACK series. I've fixed the nits noted by Joao and pushed it.

Regards,
Jim



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]