[libvirt] [PATCH v6 REBASE 5/5] vz: cleanup: define vz format of uuids

Maxim Nestratov mnestratov at virtuozzo.com
Wed May 18 08:18:42 UTC 2016


18.05.2016 10:54, Nikolay Shirokovskiy пишет:

>
> On 17.05.2016 22:02, Maxim Nestratov wrote:
>> 22.04.2016 10:20, Nikolay Shirokovskiy пишет:
>>
>>> vz puts uuids into curly braces. Simply introduce new contstant to reflect this
>>> and get rid of magic +2 in code.
>>>
>>> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
>>> ---
>>>    src/vz/vz_sdk.c   | 12 ++++++------
>>>    src/vz/vz_utils.h |  2 ++
>>>    2 files changed, 8 insertions(+), 6 deletions(-)
>> I bet we will confuse VZ_UUID_STRING_BUFLEN and VIR_UUID_STRING_BUFLEN eventually
>> That's why I doubt we need this patch
>>
> I see, what if I use VIR_UUID_STRING_BRACED_BUFLEN instead?

OK to me. But if you use VIR prefix, then it's better to define it 
beside VIR_UUID_STRING_BUFLEN




More information about the libvir-list mailing list