[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/4] qemu: Remove redundant qemuDomainAssignAddresses calls



On 05/17/2016 10:42 AM, Andrea Bolognani wrote:
> On Sat, 2016-05-14 at 16:00 -0400, Cole Robinson wrote:
>> All these calls come near immediately after parsing the domain
>> XML, which now triggers qemuDomainAssignAddresses. So drop the
>> now redundnat calls
>> ---
>>   src/qemu/qemu_driver.c | 19 -------------------
>>   1 file changed, 19 deletions(-)
> 
> This would make more sense squashed together with the previous
> commit IMHO.
> 
> ACK either way.
> 

I wanted to keep it separate incase I missed something in this part or this
part was more contentious. But I've squashed it into the previous patch

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]