Re: [libvirt] [PATCH v4 06/14] graphics: resolve address for listen type network in qemu_process

[Ján Tomko <jtomko redhat com>]

On Fri, May 20, 2016 at 09:59:43AM +0200, Pavel Hrdina wrote:
> > This is a logic change. Previously we accept this XML
> > 
> > <graphics ...>
> >   <listen type='network'/>
> > </graphics>
> > 
> > and silently treat that as using vnc_listen/spice_listen. Now we stick that
> > address in the XML like
> > 
> > <graphics ...>
> >   <listen type='network' address='$vnc_listen'/>
> > </graphics>
> 
> This isn't a logic change, it only improves the live XML, so the only change here
> is that the address will appear in the live XML. 

It would be nice to mention that in the commit message.

Jan

> If you look at the old code
> we've always used the config listen address if there wasn't any address resolved
> for listen type network.  If you look at the switch [1] we jump out from the
> switch in case there is no network specified and we use the config address [2].
>