[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/2] Yet another round of build fixes



After these regular errors, I still cannot build cleanly:

../../src/conf/domain_conf.c: In function 'virDomainChrPreAlloc':
../../src/conf/domain_conf.c:14109:57: error: potential null pointer dereference [-Werror=null-dereference]
     return VIR_REALLOC_N(*arrPtr, *cntPtr + 1);
                                                         ^
../../src/conf/domain_conf.c: In function 'virDomainChrRemove':
../../src/conf/domain_conf.c:14133:21: error: potential null pointer dereference [-Werror=null-dereference]
     for (i = 0; i < *cntPtr; i++) {
                     ^~~~~~~
cc1: all warnings being treated as errors

These are obviously false positives. I know some developers here
are not very fond of fixing those, so my question is - is it
worth the effort or will my patches be NACKed straight away?

Michal Privoznik (2):
  apibuild: Substitute only pure number tokens
  virSocketAddrIsPrivate: Work on 32bits platforms

 docs/apibuild.py         | 2 +-
 src/util/virsocketaddr.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.8.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]