[libvirt] [PATCH 4/6] qemuMonitorTextGetAllBlockStatsInfo: Fix line validation

Peter Krempa pkrempa at redhat.com
Tue May 31 10:54:00 UTC 2016


On Tue, May 31, 2016 at 12:33:30 +0200, Michal Privoznik wrote:
> There's a bug in the function. We expect the following format for
> the data we are parsing here:
> 
>   key: value
> 
> So we use strchr() to find ':' and then see if it is followed by
> space. Well, the condition which checks that - we got it wrong.

The last sentence doesn't make much sense.

> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_monitor_text.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160531/dc700c68/attachment-0001.sig>


More information about the libvir-list mailing list