[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/3] Clean up redundant usage of virDomainObjSetDefTransient

On Fri, May 27, 2016 at 17:45:13 +0200, Ján Tomko wrote:
> Commit 45ec297d from November 2010:
>     Make state driver device hotplug/update actually transient
> added virDomainObjSetDefTransient calls to the domain startup
> function in several drivers.
> In November 2011, commit 8866eed:
>     Set aliases for LXC/UML console devices
> added a call earlier in the startup function, without removing the
> existing ones.
> Also, in the UML driver it seems the function never did anything
> useful - vm->def->id is set asynchronnously in umlNotifyEvent.
> At the time of calling virDomainObjSetDefTransient with live=false,
> vm->def->id was likely still -1, making the call a no-op.

Well, since it was called earlier in the same function it was a no-op
regardless of the id :)

> ---
>  src/lxc/lxc_process.c | 4 ----
>  src/uml/uml_driver.c  | 2 +-
>  2 files changed, 1 insertion(+), 5 deletions(-)

ACK after the release.

Attachment: signature.asc
Description: Digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]