[libvirt] [PATCH v4 4/6] qemu: Save various defaults for shmem

Peter Krempa pkrempa at redhat.com
Wed Nov 2 12:33:50 UTC 2016


On Wed, Oct 26, 2016 at 12:51:35 +0200, Martin Kletzander wrote:
> We're keeping some things at default and that's not something we want to
> do intentionally.  Let's save some sensible defaults upfront in order to
> avoid having problems later.  The details for the defaults (of the newer
> implementation) can be found in qemu's commit 5400c02b90bb:
> 
>   http://git.qemu.org/?p=qemu.git;a=commit;h=5400c02b90bb
> 
> Since we are merely saving the defaults it will not change the guest ABI
> and thanks to the fact that we're doing it in the PostParse callback it
> will not break the ABI stability checks.
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  src/qemu/qemu_domain.c                             | 54 ++++++++++++++++++++++
>  tests/qemuxml2argvdata/qemuxml2argv-shmem.args     |  2 +-
>  .../qemuxml2xmlout-shmem-plain-doorbell.xml        |  5 +-
>  tests/qemuxml2xmloutdata/qemuxml2xmlout-shmem.xml  |  1 +
>  4 files changed, 60 insertions(+), 2 deletions(-)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161102/a13be320/attachment-0001.sig>


More information about the libvir-list mailing list