[libvirt] [PATCH v2] libvirt.spec: Build & run tests in parallel

Michal Privoznik mprivozn at redhat.com
Thu Nov 3 13:42:10 UTC 2016


So far, the main code is built in parallel, which makes it pretty
fast. But with a lots of tests we have now I've noticed this part
takes too much time to build. The problem was that tests were
build and run in a single job.

Also, 'make' in the first hunk is useless. The test suite is not
built due to 'make all' because there's no .git in the sources
unpacked from a tar.xz archive. It's 'make check' which triggers
tests build.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---

diff to v1:
- Instead of fixing 'make' in the first hunk, drop it from there.

 libvirt.spec.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 545990c..5133936 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1290,7 +1290,6 @@ rm -fr %{buildroot}
 
 %check
 cd tests
-make
 # These tests don't current work in a mock build root
 for i in nodeinfotest seclabeltest
 do
@@ -1299,7 +1298,7 @@ do
   printf '#!/bin/sh\nexit 0\n' > $i
   chmod +x $i
 done
-if ! make check VIR_TEST_DEBUG=1
+if ! make %{?_smp_mflags} check VIR_TEST_DEBUG=1
 then
   cat test-suite.log || true
   exit 1
-- 
2.8.4




More information about the libvir-list mailing list