[libvirt] [PATCH] vshReadlineParse: Remove unused variable
Peter Krempa
pkrempa at redhat.com
Fri Nov 4 09:18:43 UTC 2016
On Fri, Nov 04, 2016 at 09:58:53 +0100, Michal Privoznik wrote:
> After 06a7b1ff4 the @&opts_need_arg is not used anywhere. Well,
> it is set but never read:
>
> vsh.c: In function 'vshReadlineParse':
> vsh.c:2658:14: warning: variable 'opts_need_arg' set but not used [-Wunused-but-set-variable]
> uint64_t opts_need_arg, opts_seen;
> ^~~~~~~~~~~~~
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> tools/vsh.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
How about removing the complete function given it's history?
Consider this as an ACK though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161104/27ce1556/attachment-0001.sig>
More information about the libvir-list
mailing list