[libvirt] [PATCH v3] [glib 5/5] gconfig, tests: Add test case for unknown devices

Zeeshan Ali zeenix at gmail.com
Fri Nov 4 09:54:43 UTC 2016


On Thu, Nov 3, 2016 at 4:31 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Thu, Nov 03, 2016 at 02:40:58PM +0100, Zeeshan Ali wrote:
>> ---
>>  tests/test-gconfig.c                        | 24 ++++++++++++++++++++++++
>>  tests/xml/gconfig-domain-device-unknown.xml |  5 +++++
>>  2 files changed, 29 insertions(+)
>>  create mode 100644 tests/xml/gconfig-domain-device-unknown.xml
>>
>> diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c
>> index 5389a26..685cf97 100644
>> --- a/tests/test-gconfig.c
>> +++ b/tests/test-gconfig.c
>> @@ -762,6 +762,28 @@ static void test_domain_device_pci_hostdev(void)
>>      g_object_unref(G_OBJECT(domain));
>>  }
>>
>> +static void test_domain_device_unknown(void)
>> +{
>> +    GVirConfigDomain *domain;
>> +    GList *devices;
>> +    GError *error = NULL;
>> +    char *xml;
>> +
>> +    xml = load_xml("gconfig-domain-device-unknown.xml");
>> +
>> +    domain = gvir_config_domain_new_from_xml(xml, &error);
>> +    g_assert_no_error(error);
>> +
>> +    devices = gvir_config_domain_get_devices(domain);
>> +    g_assert_nonnull(devices);
>
>
> + gvir_config_domain_set_devices(domain, devices);

Ah yes. Fixed that (and adjusted the test xml), pushed the series.

Thanks.

-- 
Regards,

Zeeshan Ali




More information about the libvir-list mailing list