[libvirt] [PATCH 3/6] qemu: Add support for parsing iotune group setting

John Ferlan jferlan at redhat.com
Mon Nov 7 21:39:40 UTC 2016



On 11/02/2016 12:37 PM, Erik Skultety wrote:
> On Mon, Oct 31, 2016 at 05:22:59PM -0400, John Ferlan wrote:
>> Add support to read/parse the iotune group setting for qemu.
>>
>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>> ---
>>  include/libvirt/libvirt-domain.h |  8 +++++
>>  src/conf/domain_conf.c           |  1 +
>>  src/conf/domain_conf.h           |  1 +
>>  src/qemu/qemu_driver.c           | 50 ++++++++++++++++++++++++---
>>  src/qemu/qemu_monitor.c          |  2 ++
>>  src/qemu/qemu_monitor.h          |  1 +
>>  src/qemu/qemu_monitor_json.c     | 21 ++++++++++--
>>  src/qemu/qemu_monitor_json.h     |  1 +
>>  tests/qemumonitorjsontest.c      | 74 +++++++++++++++++++++++++++++++---------
>>  9 files changed, 134 insertions(+), 25 deletions(-)
>>
> 
> [...]
> 
>> @@ -17316,7 +17317,8 @@ qemuDomainSetBlockIoTuneDefaults(virDomainBlockIoTuneInfoPtr newinfo,
>>                                   bool set_iops_max,
>>                                   bool set_size_iops,
>>                                   bool set_bytes_max_length,
>> -                                 bool set_iops_max_length)
>> +                                 bool set_iops_max_length,
>> +                                 bool set_group_name)
>>  {
> 
> Additionally to what Martin suggested in his review, I'd like to reiterate the
> idea of converting the 8 booleans to OR'd flags.
> 

OK - I'll make an adjustment in a separate patch.

John




More information about the libvir-list mailing list