[libvirt] [PATCH v2 00/19] Redo website layout and branding

Martin Kletzander mkletzan at redhat.com
Tue Nov 8 15:11:05 UTC 2016


On Tue, Nov 08, 2016 at 01:50:33PM +0000, Daniel P. Berrange wrote:
>On Tue, Nov 08, 2016 at 02:48:07PM +0100, Martin Kletzander wrote:
>> On Tue, Nov 08, 2016 at 11:50:11AM +0000, Daniel P. Berrange wrote:
>> > The current libvirt website design dates from 2008 and
>> > has not changed significantly since. Compared to
>> > contemporary open source project websites it looks
>> > pretty dated and cluttered.
>> >
>> > This series incrementally changes the website to have
>> > a completely new layout and branding.
>> >
>> > Since the original adobe illustrator files are long
>> > since lost, this series introduces a newly created
>> > variant of the libvirt logo with Inkscape as an SVG
>> > file.
>> >
>> > The libvirt logo used a specific font with angled tops
>> > to letters like "l", "b" and "t" - this is the "Overpass"
>> > font, made available by Red Hat under an open source
>> > font license. The re-branding makes use of webfont
>> > support so that we can use this font across the entire
>> > libvirt website for a consistent look.
>> >
>> > The colors of the website CSS now exactly match the
>> > colors used in the logo in most places.
>> >
>> > The bigger change is in the layout, with the huge
>> > left hand sitemap nav bar being removed to give more
>> > space to the main content. The front page now directly
>> > links to the key pages that were shown to be highly
>> > visited in the apache web logs. Most of the rest of
>> > the links are now available from the "docs.html" page
>> > linked from "Learn" in the top nav bar.
>> >
>> > Another key change is that the download page now
>> > covers all language bindings, test suites, docs
>> > released by the project, not merely the core C
>> > library.
>> >
>> > Finally a new page "contribute.html" is added as the
>> > source of information useful to people wishing to get
>> > involved in the libvirt project.
>> >
>> > View the new site here
>> >
>> > v2: https://berrange.fedorapeople.org/libvirt-new-website-v2/
>> > v1: https://berrange.fedorapeople.org/libvirt-new-website/
>> >
>>
>> ACK from me, though you might want for outhers to check how it looks for
>> them (e.g. Peter).
>>
>> Two things I noticed that I can't really find what patch caused it, so
>> I'll not them here.  The table in hvsupport.pl looks weird because it is
>> so wide.  It would be OK if it were centered.
>
>Ah, interesting. That is because I put "max-width: 60em" on the body
>content. The table is clearly wider than that, and so spills over
>the right hand margin. I'll add some custom css for the table to
>fix that - basically will make it ignore the max-width, but keep
>centered.
>
>> the stuff in <pre> has line-height of 150% if it is in a <dl/> tag,
>> which makes some pages with different <pre/> tags inconsistent.  Adding
>> simple:
>> pre { line-height: 100%; }
>> ought to do, I guess.
>
>Can you point me to a page showing the problem so I can better understand
>it.
>

Sorry, I ended the paragraph in a rush with one hand while holding a
child in the other one =)  If you look here:

https://berrange.fedorapeople.org/libvirt-new-website-v2/formatnetwork.html

The unindented (e.g. first two) blocks look normal, but the indented,
because they are inside <dl/> (e.g. the next two at least) have more
space in between the lines.  Inspecting that element in Firefox, it
tells me that the property is inherited from <dl/> (so that you know how
I got that info).  I have no preference in how it's fixed as long as
it's consistent.

Thanks a lot for looking into this and redoing the design, I really
appreciate that.

Martin

>Regards,
>Daniel
>--
>|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
>|: http://libvirt.org              -o-             http://virt-manager.org :|
>|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161108/b06100b1/attachment-0001.sig>


More information about the libvir-list mailing list