[libvirt] [PATCH] Pass GPG_TTY env var to the ssh binary

[Daniel P. Berrange]

On Sat, Nov 12, 2016 at 02:19:37PM +0100, Guido Günther wrote:
> This came in via the Debian BTS:
> 
> http://bugs.debian.org/43863

This seems to be the wrong bug number.

> 
> and it looks good to me.
> 
> >From 7eeec0664ed2c4986172b67815d2ecf5432d0a40 Mon Sep 17 00:00:00 2001
> Message-Id: <7eeec0664ed2c4986172b67815d2ecf5432d0a40.1478956627.git.agx at sigxcpu.org>
> From: Guilhem Moulin <guilhem at guilhem.org>
> Date: Thu, 10 Nov 2016 11:17:05 +0100
> Subject: [PATCH] Pass GPG_TTY env var to the ssh binary
> To: libvir-list at redhat.com
> Status: O
> Content-Length: 694
> Lines: 18
> 
> ---
>  src/rpc/virnetsocket.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
> index 405f5ba..95cda86 100644
> --- a/src/rpc/virnetsocket.c
> +++ b/src/rpc/virnetsocket.c
> @@ -839,6 +839,7 @@ int virNetSocketNewConnectSSH(const char *nodename,
>      virCommandAddEnvPassBlockSUID(cmd, "KRB5CCNAME", NULL);
>      virCommandAddEnvPassBlockSUID(cmd, "SSH_AUTH_SOCK", NULL);
>      virCommandAddEnvPassBlockSUID(cmd, "SSH_ASKPASS", NULL);
> +    virCommandAddEnvPassBlockSUID(cmd, "GPG_TTY", NULL);
>      virCommandAddEnvPassBlockSUID(cmd, "DISPLAY", NULL);
>      virCommandAddEnvPassBlockSUID(cmd, "XAUTHORITY", NULL);
>      virCommandClearCaps(cmd);

Can you explain what functional effect a GPG setting has on SSH ?!?!?!?


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|