[libvirt] [PATCH] news: Add modern ivshmem support

Martin Kletzander mkletzan at redhat.com
Mon Nov 21 21:20:13 UTC 2016


On Mon, Nov 21, 2016 at 04:15:44PM +0100, Andrea Bolognani wrote:
>On Mon, 2016-11-21 at 13:26 +0100, Martin Kletzander wrote:
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  docs/news.html.in | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/docs/news.html.in b/docs/news.html.in
>> index fca1e29d043c..473c2ead13b4 100644
>> --- a/docs/news.html.in
>> +++ b/docs/news.html.in
>> @@ -22,6 +22,9 @@
>>       List user-visible changes instead of single commits for a better
>>       high-level overview of differences between libvirt releases
>>       </li>
>> +     <li>The shmem device can now utilize qemu's ivshmem-plain and
>> +     ivshmem-doorbell, more modern versions of ivshmem
>> +     </li>
>>       <li>Various bug fixes and improvements</li>
>>     </ul>
>
>I was thinking more of along the lines of
>
>  One-line summary
>  Couple of sentences that actually explain the change
>
>How about this instead?
>
>  <li>Add support for additional shmem models<br/>
>  The shmem device can now utilize QEMU's ivshmem-plain and
>  ivshmem-doorbell, more modern versions of ivshmem
>  </li>
>
>I made QEMU uppercase while at it ;)
>

Sure, but in this case you want to separate the summary from the
explanation.  Either using <dl/> instead of <ul/> or at least making the
one line summary bold or something.  I'm afraid, though, that the
multiline requirement will drive even more people away from writing
anything in the news file.  But as you said, we can do style changes
later on.

Does that mean ACK on your version? =D

>-- 
>Andrea Bolognani / Red Hat / Virtualization
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161121/e0ce8bba/attachment-0001.sig>


More information about the libvir-list mailing list