[libvirt] [PATCH] Revert "vz: fixed race in vzDomainAttach/DettachDevice"

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Tue Nov 22 12:05:28 UTC 2016


ACK

On 18.11.2016 19:16, Maxim Nestratov wrote:
> This reverts commit 3a6cf6fc16.
> 
> Mistakenly this commit was pushed because I thought I missed the
> corret one b880ff42ddb while in fact I didn't.
> 
> Signed-off-by: Maxim Nestratov <mnestratov at virtuozzo.com>
> ---
>  src/vz/vz_sdk.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
> index d61bccf..f63b9a3 100644
> --- a/src/vz/vz_sdk.c
> +++ b/src/vz/vz_sdk.c
> @@ -3552,12 +3552,6 @@ prlsdkAttachDevice(vzDriverPtr driver,
>          return -1;
>      }
>  
> -    if (prlsdkUpdateDomain(driver, dom) < 0) {
> -        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> -                        _("Failed to save new config"));
> -        return -1;
> -    }
> -
>      job = PrlVm_CommitEx(privdom->sdkdom, PVCF_DETACH_HDD_BUNDLE);
>      if (PRL_FAILED(waitDomainJob(job, dom)))
>          return -1;
> @@ -3623,12 +3617,6 @@ prlsdkDetachDevice(vzDriverPtr driver ATTRIBUTE_UNUSED,
>          goto cleanup;
>      }
>  
> -    if (prlsdkUpdateDomain(driver, dom) < 0) {
> -        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> -                        _("Failed to save new config"));
> -        goto cleanup;
> -    }
> -
>      job = PrlVm_CommitEx(privdom->sdkdom, PVCF_DETACH_HDD_BUNDLE);
>      if (PRL_FAILED(waitDomainJob(job, dom)))
>          goto cleanup;
> 




More information about the libvir-list mailing list