[libvirt] [PATCH] news: Add modern ivshmem support
Andrea Bolognani
abologna at redhat.com
Tue Nov 22 13:46:44 UTC 2016
On Mon, 2016-11-21 at 22:20 +0100, Martin Kletzander wrote:
> > > + <li>The shmem device can now utilize qemu's ivshmem-plain and
> > > + ivshmem-doorbell, more modern versions of ivshmem
> > > + </li>
> >
> > I was thinking more of along the lines of
> >
> > One-line summary
> > Couple of sentences that actually explain the change
> >
> > How about this instead?
> >
> > <li>Add support for additional shmem models<br/>
> > The shmem device can now utilize QEMU's ivshmem-plain and
> > ivshmem-doorbell, more modern versions of ivshmem
> > </li>
> >
> > I made QEMU uppercase while at it ;)
>
> Sure, but in this case you want to separate the summary from the
> explanation.
That's what the <br/> is supposed to do. Not the most
elegant solution, I agree.
> Either using <dl/> instead of <ul/> or at least making the
> one line summary bold or something.
We don't want the HTML version to be a complete bold-fest,
but the <dl> idea is definitely worth investigating.
Do you feel like looking into that? Otherwise I'll do it,
but be warned that it might be a while before I can bring
myself to touch XSLT again :S
> I'm afraid, though, that the
> multiline requirement will drive even more people away from writing
> anything in the news file.
Mh, I didn't consider that. You might be right... On the
other hand, it's something that can easily be addressed
during review, and if someone has already provided a 90%
good NEWS file entry they probably won't back out just
because of the need for some minor tweaking.
> But as you said, we can do style changes
> later on.
We certainly can, and quite probably will ;)
> Does that mean ACK on your version? =D
Well, it's been pushed already ;)
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list