[libvirt] [PATCH v4 4/9] qemu: Add vhost-scsi string for -device parameter

[Eric Farman]

On 11/22/2016 04:08 PM, John Ferlan wrote:
> [...]
>
>>   
>>   void
>> +qemuHostdevReAttachSCSIVHostDevices(virQEMUDriverPtr driver,
>> +                                    const char *name,
>> +                                    virDomainHostdevDefPtr *hostdevs,
>> +                                    int nhostdevs)
>> +{
>> +    size_t i;
>> +    virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr;
>> +
>> +    for (i = 0; i < nhostdevs; i++) {
>> +        virDomainHostdevDefPtr hostdev = hostdevs[i];
>> +        virDomainDeviceDef dev;
>> +
>> +        dev.type = VIR_DOMAIN_DEVICE_HOSTDEV;
>> +        dev.data.hostdev = hostdev;
>> +
>> +        ignore_value(qemuRemoveSharedDevice(driver, &dev, name));
>> +    }
> This whole loop won't be necessary, true?  Since this isn't shared (it
> does nothing for now).
>
> I can remove before pushing - just confirm my suspicion...

Thank you for removing, you are correct.

>
> ACK,
>
> John
>