[libvirt] [PATCH] daemon: Install virt-guest-shutdown.target properly
Nikolay Shirokovskiy
nshirokovskiy at virtuozzo.com
Wed Nov 30 14:38:49 UTC 2016
On 29.11.2016 18:38, Michal Privoznik wrote:
> When trying to install libvirtd from sources I've noticed the
> following failure:
>
> /usr/bin/install: cannot stat 'virt-guest-shutdown.target': No such file or directory
> Makefile:2792: recipe for target 'install-init-systemd' failed
> make[3]: *** [install-init-systemd] Error 1
> make[3]: *** Waiting for unfinished jobs....
>
> The problem is that while other files around that location in
> Makefile are firstly generated into the builddir and only after
> that installed, virt-guest-shutdown.target file is not generated
> at all and should be installed from the srcdir.
>
> This was introduced in 01079727.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>
> Pushed under build-breaker & trivial rules.
>
> daemon/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/daemon/Makefile.am b/daemon/Makefile.am
> index 463db6e..60c7368 100644
> --- a/daemon/Makefile.am
> +++ b/daemon/Makefile.am
> @@ -457,7 +457,7 @@ install-init-systemd: install-sysconfig libvirtd.service
> $(MKDIR_P) $(DESTDIR)$(SYSTEMD_UNIT_DIR)
> $(INSTALL_DATA) libvirtd.service \
> $(DESTDIR)$(SYSTEMD_UNIT_DIR)/libvirtd.service
> - $(INSTALL_DATA) virt-guest-shutdown.target \
> + $(INSTALL_DATA) $(srcdir)/virt-guest-shutdown.target \
> $(DESTDIR)$(SYSTEMD_UNIT_DIR)/virt-guest-shutdown.target
>
> uninstall-init-systemd: uninstall-sysconfig
>
I missed this situation in test, VPATH build.
ACK
More information about the libvir-list
mailing list