[libvirt] [PATCH v3 07/18] conf: make virDomainPCIAddressGetNextSlot() a local static function
Andrea Bolognani
abologna at redhat.com
Mon Oct 3 12:31:55 UTC 2016
On Tue, 2016-09-20 at 15:14 -0400, Laine Stump wrote:
> This function is no longer needed outside of domain_addr.c.
> ---
> src/conf/domain_addr.c | 2 +-
> src/conf/domain_addr.h | 5 -----
> src/libvirt_private.syms | 1 -
> 3 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
> index f735fb4..be42f15 100644
> --- a/src/conf/domain_addr.c
> +++ b/src/conf/domain_addr.c
> @@ -591,7 +591,7 @@ virDomainPCIAddressSetFree(virDomainPCIAddressSetPtr addrs)
> }
>
>
> -int
> +static int
> virDomainPCIAddressGetNextSlot(virDomainPCIAddressSetPtr addrs,
> virPCIDeviceAddressPtr next_addr,
> virDomainPCIConnectFlags flags)
> diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h
> index 904d060..4d6d12a 100644
> --- a/src/conf/domain_addr.h
> +++ b/src/conf/domain_addr.h
> @@ -155,11 +155,6 @@ int virDomainPCIAddressReleaseSlot(virDomainPCIAddressSetPtr addrs,
> virPCIDeviceAddressPtr addr)
> ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
>
> -int virDomainPCIAddressGetNextSlot(virDomainPCIAddressSetPtr addrs,
> - virPCIDeviceAddressPtr next_addr,
> - virDomainPCIConnectFlags flags)
> - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
These attributes are lost when you make the function static.
ACK
--
Andrea Bolognani / Red Hat / Virtualization
More information about the libvir-list
mailing list