[libvirt] [PATCH 2/2] qemu: attach: Close monitor socket on connection failure

Ján Tomko jtomko at redhat.com
Mon Oct 3 15:35:38 UTC 2016


On Mon, Oct 03, 2016 at 01:32:47PM +0200, Peter Krempa wrote:
>If attaching to a qemu process fails after opening the monitor socket
>libvirt does not clean up the monitor. As the monitor also holds a
>reference to the domain object the qemu attach API basically leaks it.
>
>QEMU also does not interact on a second monitor connection and thus a
>further attempt to attach to it would lock up.
>
>Prevent libvirt from leaking the monitor by explicitly closing it.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1378401
>---
> src/qemu/qemu_process.c | 3 +++
> 1 file changed, 3 insertions(+)
>

ACK

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161003/e2e953e2/attachment-0001.sig>


More information about the libvir-list mailing list