[libvirt] [PATCH v2 06/20] virlog: Introduce virLogDefineFilters

[Erik Skultety]

>> + */
>> +int
>> +virLogDefineFilters(virLogFilterPtr *filters, size_t nfilters)
>> +{
>> +    if (virLogInitialize() < 0)
>> +        return -1;
>> +
>> +    virLogLock();
>> +    virLogResetOutputs();
> 
> Copy/Paste error - s/b virLogResetFilters(); ?
> 
>> +    virLogFilters = filters;
>> +    virLogNbOutputs = nfilters;
> 
> Similar copy/paste error s/b virLogNbFilters
> 
>> +    virLogFiltersSerial++;
> 
> And since virLogResetFilters updates this, it's not required to do it
> twice right?

You're absolutely right, I failed to see it but since we're already
holding the lock on the mutex, despite the fact that serial testing is
done concurrently, no source update can take place unless the lock is
released, thanks.

Erik

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161003/6c7af637/attachment-0001.sig>