[libvirt] [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised
Ian Jackson
ian.jackson at eu.citrix.com
Tue Oct 4 17:02:27 UTC 2016
Currently, osstest wrongly thinks that ARM can do save/restore,
because `virsh help' does mention the save command (on all
architectures).
Additionally, check the virth capabilities xpath
/capabilities/host/migration_features
to try to see whether this host supports migration.
I am not sure if this is the right path to check. Perhaps
/capabilities/host/migration_features/live
is more correct, but this may be wrong if Xen comes to support save/restore
on ARM, but not live migration (but perhaps libvirt cannot express this
distinction in which case perhaps it's right after all).
Signed-off-by: Ian Jackson <Ian.Jackson at eu.citrix.com>
CC: Julien Grall <julien.grall at arm.com>
CC: Jim Fehlig <jfehlig at suse.com>
---
Osstest/Toolstack/libvirt.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Osstest/Toolstack/libvirt.pm b/Osstest/Toolstack/libvirt.pm
index b7db7af..250fe47 100644
--- a/Osstest/Toolstack/libvirt.pm
+++ b/Osstest/Toolstack/libvirt.pm
@@ -111,7 +111,9 @@ sub check_for_command($$) {
sub saverestore_check ($) {
my ($self) = @_;
- return check_for_command($self, "save");
+ return
+ _check_capability($self, '/capabilities/host/migration_features') &&
+ check_for_command($self, "save");
}
sub migrate ($$$$) {
--
2.1.4
More information about the libvir-list
mailing list